Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Add aura method for conditional trigger contexts - Update glow! to support operator parsing (>=, ==, etc) - Enable nested conditionals via stacks/charges with blocks - Pass parent node context to triggers for glow! forwarding - Clean up commented code in examples
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
==========================================
- Coverage 62.29% 56.78% -5.52%
==========================================
Files 15 35 +20
Lines 244 678 +434
Branches 0 29 +29
==========================================
+ Hits 152 385 +233
- Misses 92 281 +189
- Partials 0 12 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive conditional logic support to WeakAura nodes, bringing back icon creation functionality and introducing nested condition handling. The changes enable more sophisticated WeakAura configurations with operator parsing and conditional triggers.
Key changes:
- Restores
iconmethod and addsaction_usable!for creating conditional action triggers - Implements operator parsing for conditions (>=, ==, <, etc.) with support for spell counts, charges, and stacks
- Adds
auramethod for buff/debuff conditional contexts with nested condition blocks
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| public/node.rb | Core conditional logic implementation with operator parsing and aura context support |
| public/weak_aura/icon.rb | Icon node creation with action_usable! method and conditional trigger support |
| public/weak_aura/triggers.rb | Base trigger functionality with charges/stacks methods and glow! forwarding |
| public/weak_aura/triggers/action_usable.rb | ActionUsable trigger with charges support and operator parsing |
| public/examples/* | Updated example configurations demonstrating new conditional syntax |
| .devcontainer/* | Development environment configuration updates |
| *_spec.rb | Test files for new functionality |
Comments suppressed due to low confidence (2)
- Remove trailing whitespace - Fix comment grammar to present tense
- Add tests for parse_operator method - Add tests for aura method and parent_node context - Add tests for glow! with charges condition - Add tests for charges/stacks methods with blocks - Add tests for trigger glow! forwarding to parent - Add tests for action_usable! block execution
- Use string keys consistently in glow! condition hash - Initialize @parent_node in Trigger::Base constructor - Remove duplicate parent_node assignments in methods
- Update Node#glow! to accept **options instead of options hash - Update Trigger::Base#glow! to forward keyword arguments properly - Fixes RSpec test failure expecting keyword arguments
- Test initialization with spell and spell_name options - Test exact option behavior - Test full trigger JSON structure generation - Test charges option with operators - Test omission of optional fields - Test combination of spell_count and charges - Increase coverage from 40% to near 100%
- Add tests for remaining_time method in Trigger::Base - Add test for all_triggers! method in Icon - Add test for hide_ooc! method in Node - Cover all 4 remaining missing lines - Achieve 100% patch coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
icon, add the standard Action Usable trigger viaaction_usable!Features
iconmethod to create icon nodes with conditional triggersaction_usable!method with block support for nested conditionsauramethod for buff/debuff conditional contextsstacks,chargesmethods with glow! supportspell_count: '>= 2')Example Usage
Changes
auramethod to Node for creating conditional trigger contextsglow!method to support operator parsingglow!calls to parent nodes